stats

src/osmfixer/index/StatIdx.cpp

@@ -186,6 +186,8 @@ void StatIdx::readFromFile(const std::string& path) {
     addGroupToMeta(gid, osmid);
   }
 
+  _numOSMMetaGroups = _metaGroups.size();
+
   LOG(INFO) << "Done.";
 
   LOG(INFO) << "Init groups";
@@ -201,6 +203,23 @@ void StatIdx::readFromFile(const std::string& path) {
   LOG(INFO) << "Building indices...";
   initIndex();
   LOG(INFO) << "Done.";
+
+  LOG(INFO) << "Input Stats:";
+  LOG(INFO) << _numOSMStations << " OSM stations";
+  LOG(INFO) << _numOSMGroups << " OSM groups";
+  LOG(INFO) << _numOSMMetaGroups << " OSM meta groups";
+
+  LOG(INFO) << "Suggestion Stats:";
+  LOG(INFO) << _numOK << " objects OK";
+  LOG(INFO) << _numDL << " stations should be removed from their group (DL)";
+  LOG(INFO) << _numMV << " stations should be moved into another group (MV)";
+  LOG(INFO) << _numGR << " stations should be moved into a group (GR)";
+  LOG(INFO) << _numCR
+            << " stations should be moved into newly created groups (CR)";
+  LOG(INFO) << _numER << " tags were marked as erroneous (ER)";
+  LOG(INFO) << _numMG << " relations should be merged (MG)";
+  LOG(INFO) << _numNM << " objects should be outfitted with a name (NM)";
+  LOG(INFO) << _numTR << " station names are most likely track numbers";
 }
 
 // _____________________________________________________________________________
@@ -214,6 +233,7 @@ void StatIdx::addGroupToMeta(size_t gid, size_t metaId) {
 void StatIdx::addStation(int64_t osmid, const util::geo::DLine& geom,
                          const util::geo::DLine& latLngs, size_t origGroup,
                          size_t group, const OsmAttrs& attrs) {
+  _numOSMStations++;
   auto centroid = util::geo::centroid(latLngs);
   _stations.emplace_back(Station{_stations.size(),
                                  osmid,
@@ -232,6 +252,7 @@ void StatIdx::addStation(int64_t osmid, const util::geo::DLine& geom,
 
 // _____________________________________________________________________________
 void StatIdx::addGroup(size_t osmid, const OsmAttrs& attrs) {
+  if (osmid > 1) _numOSMGroups++;
   Group g;
   g.id = _groups.size();
   g.osmid = osmid;
@@ -254,7 +275,6 @@ void StatIdx::initMetaGroups() {
     mg.poly = hull(mp, 11);
     assert(mg.poly.getOuter().size());
 
-
     for (auto p : mg.poly.getOuter()) {
       mg.llPoly.getOuter().push_back(
           util::geo::webMercToLatLng<double>(p.getX(), p.getY()));
@@ -680,6 +700,8 @@ void StatIdx::initSuggestions() {
       sug.type = 7;
       _suggestions.push_back(sug);
       group.suggestions.push_back(_suggestions.size() - 1);
+
+      if (group.osmid > 2) _numNM++;
     }
 
     Suggestion sug;
@@ -699,6 +721,8 @@ void StatIdx::initSuggestions() {
         auto b = util::geo::centroid(
             getMetaGroup(getGroup(group.mergeId)->metaGroupId)->poly);
         sug.arrow = getGroupArrow(a, b);
+
+        _numMG++;
       } else {
         // merge two groups
         sug.type = 9;
@@ -710,6 +734,8 @@ void StatIdx::initSuggestions() {
         auto a = util::geo::centroid(group.poly);
         auto b = util::geo::centroid(getGroup(group.mergeId)->poly);
         sug.arrow = getGroupArrow(a, b);
+
+        _numMG++;
       }
 
       _suggestions.push_back(sug);
@@ -734,6 +760,9 @@ void StatIdx::initSuggestions() {
 
         _suggestions.push_back(sug);
         group.suggestions.push_back(_suggestions.size() - 1);
+
+        _numTR++;
+        _numER++;
       } else if (otherGrp->osmid == group.osmid) {
         if (suggested.count({attrErr.attr, 6})) continue;
         // fix attributes
@@ -747,8 +776,12 @@ void StatIdx::initSuggestions() {
 
         _suggestions.push_back(sug);
         group.suggestions.push_back(_suggestions.size() - 1);
+
+        _numER++;
       }
     }
+
+    if (group.suggestions.size() + group.attrErrs.size() == 0) _numOK++;
   }
 
   // station suggestions
@@ -763,6 +796,8 @@ void StatIdx::initSuggestions() {
       sug.type = 7;
       _suggestions.push_back(sug);
       stat.suggestions.push_back(_suggestions.size() - 1);
+
+      _numNM++;
     }
 
     Suggestion sug;
@@ -789,6 +824,9 @@ void StatIdx::initSuggestions() {
 
         _suggestions.push_back(sug);
         stat.suggestions.push_back(_suggestions.size() - 1);
+
+        _numTR++;
+        _numER++;
       } else if (otherStat->osmid == stat.osmid) {
         if (suggested.count({attrErr.attr, 6})) continue;
         suggested.insert({attrErr.attr, 6});
@@ -802,6 +840,8 @@ void StatIdx::initSuggestions() {
 
         _suggestions.push_back(sug);
         stat.suggestions.push_back(_suggestions.size() - 1);
+
+        _numER++;
       }
     }
 
@@ -819,6 +859,7 @@ void StatIdx::initSuggestions() {
           _suggestions.push_back(sug);
           stat.suggestions.push_back(_suggestions.size() - 1);
 
+          _numCR++;
         } else if (getGroup(stat.group)->osmid > 1) {
           // move orphan into existing group
           sug.type = 2;
@@ -830,6 +871,8 @@ void StatIdx::initSuggestions() {
 
           _suggestions.push_back(sug);
           stat.suggestions.push_back(_suggestions.size() - 1);
+
+          _numGR++;
         }
       } else {
         if (getGroup(stat.group)->osmid == 1 &&
@@ -845,6 +888,8 @@ void StatIdx::initSuggestions() {
 
           _suggestions.push_back(sug);
           stat.suggestions.push_back(_suggestions.size() - 1);
+
+          _numCR++;
         } else if (getGroup(stat.group)->osmid > 1) {
           if (stat.group != getGroup(stat.origGroup)->mergeId) {
             // move station from relation into existing group
@@ -852,9 +897,10 @@ void StatIdx::initSuggestions() {
             sug.target_gid = stat.group;
             sug.target_osm_rel_id = getGroup(stat.group)->osmid;
 
-            // dont output arrow if move is part of a group merge
             auto b = util::geo::centroid(getGroup(stat.group)->poly);
             sug.arrow = getGroupArrow(centroid, b);
+
+            _numMV++;
           } else {
             continue;
             // size_t metaId =
@@ -893,9 +939,13 @@ void StatIdx::initSuggestions() {
 
           _suggestions.push_back(sug);
           stat.suggestions.push_back(_suggestions.size() - 1);
+
+          _numDL++;
         }
       }
     }
+
+    if (stat.suggestions.size() + stat.attrErrs.size() == 0) _numOK++;
   }
 }
 

src/osmfixer/index/StatIdx.h

@@ -105,7 +105,19 @@ struct Cluster {
 
 class StatIdx {
  public:
-  StatIdx() {}
+  StatIdx()
+      : _numOSMStations(0),
+        _numOSMGroups(0),
+        _numOSMMetaGroups(0),
+        _numOK(0),
+        _numDL(0),
+        _numMV(0),
+        _numGR(0),
+        _numCR(0),
+        _numER(0),
+        _numMG(0),
+        _numNM(0),
+        _numTR(0) {}
 
   void readFromFile(const std::string& path);
 
@@ -171,6 +183,21 @@ class StatIdx {
   std::vector<util::geo::Grid<Cluster, util::geo::Point, double>>
       _heatGridsSugg;
   std::vector<util::geo::Grid<Cluster, util::geo::Point, double>> _heatGridsErr;
+
+  size_t _numOSMStations;
+  size_t _numOSMGroups;
+  size_t _numOSMMetaGroups;
+  size_t _numOK;
+  size_t _numDL;
+  size_t _numMV;
+  size_t _numGR;
+  size_t _numCR;
+  size_t _numER;
+
+  size_t _numMG;
+
+  size_t _numNM;
+  size_t _numTR;
 };
 }  // namespace osmfixer
 

web/script.js

@@ -145,7 +145,7 @@ function rndrSt(stat) {
 
     if (stat.attrs.name) con.innerHTML += " (<b>\"" + stat.attrs.name + "\"</b>)";
 
-    con.innerHTML += "<a class='ebut' target='_blank' href='" + osmUrl + ident.toLowerCase() + "=" + osmid +"'>&#9998;</a>";
+    con.innerHTML += "<a class='ebut' target='_blank' href='" + osmUrl + "edit?" + ident.toLowerCase() + "=" + osmid +"'>&#9998;</a>";
 
     var attrTbl = $$('table');
     attrTbl.setAttribute("id", "attr-tbl")
@@ -242,7 +242,7 @@ function rndrGr(grp) {
 
         if (grp.attrs.name) con.innerHTML += " (<b>\"" + grp.attrs.name + "\"</b>)";
 
-        con.innerHTML += "<a class='ebut' target='_blank' href='https://www.openstreetmap.org/edit?relation=" + grp.osmid +"'>&#9998;</a>";
+        con.innerHTML += "<a class='ebut' target='_blank' href='" + osmUrl + "edit?relation=" + grp.osmid +"'>&#9998;</a>";
     }
 
     var attrTbl = $$('table');
@@ -355,7 +355,7 @@ function rndrMGr(grp) {
     oldMembers.innerHTML = "<span class='oldmemberstit'>Members</span>";
 
     con.innerHTML = "OSM relation <a target='_blank' href='https://www.openstreetmap.org/relation/" + grp.osmid + "'>" + grp.osmid + " </a> (<tt>public_transport=stop_area_group</tt>)";
-    con.innerHTML += "<a class='ebut' target='_blank' href='https://www.openstreetmap.org/edit?relation=" + grp.osmid +"'>&#9998;</a>";
+    con.innerHTML += "<a class='ebut' target='_blank' href='" + osmUrl + "edit?relation=" + grp.osmid +"'>&#9998;</a>";
 
     con.appendChild(oldMembers);